Is flipEnvMap really needed?

amsXYZ · January 4, 2020, 12:33pm

First of all, first post here!

I’ve been working on a custom multi-faceted glass ShaderMaterial these days (link) and while working on it, I almost lost my mind (as a graphics programmer does on a daily basis) trying to understand why my refraction/reflection code was being flipped… Until I found out about flipEnvMap!

Why was this implemented in the first place? Shouldn’t panorama and cube maps be sampled with the same ray? I’ve read through source a bit and it seems to be this way to not break old examples (link).

If this is the case, I think this is the wrong approach as some technical debt is being created (which is confusing advanced developers that want to play around with cube refraction/reflection, not just me), instead of fixing the old examples.

The code to fix this in your custom shaders is not too complex, but the path to figure out that the cube map was being flipped and your math is not wrong still scares me when I think about it…

Mugen87 · October 10, 2020, 6:14pm

Since this topic caused some confusion in the past, we’ve decided to clarify things when refactoring the internal processing of WebGLCubeRenderTarget. The CubeTexture class has now a flag which controls the flip and it comes with a detailed documentation:

github.com

mrdoob/three.js/blob/25e4e946fa2e69240a36c1263477aa0188231706/src/textures/CubeTexture.js#L14-L24


	// Why CubeTexture._needsFlipEnvMap is necessary:
	//
	// By convention -- likely based on the RenderMan spec from the 1990's -- cube maps are specified by WebGL (and three.js)
	// in a coordinate system in which positive-x is to the right when looking up the positive-z axis -- in other words,
	// in a left-handed coordinate system. By continuing this convention, preexisting cube maps continued to render correctly.

	// three.js uses a right-handed coordinate system. So environment maps used in three.js appear to have px and nx swapped
	// and the flag _needsFlipEnvMap controls this conversion. The flip is not required (and thus _needsFlipEnvMap is set to false)
	// when using WebGLCubeRenderTarget.texture as a cube texture.

	this._needsFlipEnvMap = true;

Topic		Replies	Views
Is it possible to animate an envimaps rotation? Questions environment-map , envmap	4	2289	March 24, 2022
Offset (or rotate) the envMap Questions environment-map	8	8872	May 21, 2021
Flipped maps from Blender Questions textures , materials , geometry	8	1838	March 19, 2019
Environment map not working Questions environment-map	6	6169	October 22, 2018
Parallax correction from environment Maps Questions environment-map , cube-camera , envmap	4	2416	February 14, 2022

Is flipEnvMap really needed?

Related topics