Environment Map / PMREM Regression?

environment-map

#1

I’m currently in the process of upgrading Mozilla Hubs from AFrame 0.8.2 + Three.js v95 to AFrame master + Three.js v101. Upgrading has been fairly smooth except for some issues with environment maps / IBL.

Here’s what I’m seeing:

I believe this is related to this PR: https://github.com/mrdoob/three.js/pull/15644

After reverting the changes in that PR I get the following result:

Is this a regression or could I be doing something wrong when using THREE.PMREMGenerator?

Here is the code where I am generating the environment map: https://github.com/mozilla/hubs/blob/master/src/components/skybox.js#L297

Let me know if there’s more information I can provide. I can also move this into an issue if it is determined that it’s not something I’m doing wrong on my side.

Thanks,

Robert


#2

Can you highlight the differences between the images? I can see that the bricks are much more pronounced in the R101 screen shot. Are there other issues?


#4

I notice the bricks being brighter along the edges as well, if this is a Standard/Physical shader, what are its metalness/roughness values? Do you have the material settings + textures available?


#5

@looeee @jsantell Here is the model from the screenshot: https://sketchfab.com/models/bc1046092d334bbbacdb40c1cf8796cd

The glTF exported from sketchfab has the materials settings and textures. It does look like the issues occur where the normal map has extreme discontinuities. The tiles and the wood beams are the main examples of this in the scene.