Use RGBFormat/RGBAFormat or use userData.mimeType to control export image format

orion_prime · May 26, 2022, 4:39pm

so in the newer versions THREE.RGBFormat is removed and texture.userData.mimeType is introduced to maintain input file format on export
GLTF exporter uses this new method whereas USDZ exporter uses the old RGB vs RGBA method

github.com

mrdoob/three.js/blob/0c26bb4bb8220126447c8373154ac045588441de/examples/jsm/exporters/USDZExporter.js#L63

      
        
            
            
		output += buildMaterials( materials, textures );
            
            
		files[ modelFileName ] = fflate.strToU8( output );
            		output = null;
            
            
		for ( const id in textures ) {
            
            
			const texture = textures[ id ];
            			const color = id.split( '_' )[ 1 ];
            			const isRGBA = texture.format === 1023;
            
            
			const canvas = imageToCanvas( texture.image, color );
            			const blob = await new Promise( resolve => canvas.toBlob( resolve, isRGBA ? 'image/png' : 'image/jpeg', 1 ) );
            
            
			files[ `textures/Texture_${ id }.${ isRGBA ? 'png' : 'jpg' }` ] = new Uint8Array( await blob.arrayBuffer() );
            
            
		}
            
            
		// 64 byte alignment
            		// https://github.com/101arrowz/fflate/issues/39#issuecomment-777263109

i’m guessing usdzExp will also get updated to use texture.userData.mimeType too ?
and is RGBFormat going to be fully deprecated ?(the constant still exists right now)

donmccurdy · May 26, 2022, 5:52pm

I’m not sure what USDZExporter should do (that’s very subjective, what if you always want lossless export?) but yeah — THREE.RGBFormat is not very efficient and it’s generally better to use RGBAFormat now. The underlying WebGL enum is not going away of course, so I don’t know if the three.js enum would actually be deprecated.

Topic		Replies	Views
Using THREE.RGBAFormat instead of THREE.RGBFormat Questions textures	7	2395	October 12, 2023
GLTFExporter and TextureData Questions textures , gltf-exporter	11	1804	October 30, 2020
Attempted import error: 'RGBFormat' is not exported from 'three' (imported as 'RGBFormat10') Questions	4	4936	March 12, 2023
How to export mesh with canvas texture as USDZ Questions textures , materials , usdz	3	1019	February 9, 2021
Gltf loader, where do we find the image src and the source image data ( threejs r119 ) Questions exporter , textures , json-format , gltf-loader , gltf	4	1969	August 12, 2020

Use RGBFormat/RGBAFormat or use userData.mimeType to control export image format

Related topics