RenderPass appears to write to the "readBuffer"?

alecmce · July 23, 2021, 2:22pm

In RenderPass.js, why does it write to the readBuffer? It feels to me that either the names are the wrong way around, or some sort of comment would be friendly.

github.com

mrdoob/three.js/blob/3a9152af37e7879e5ed41cb60c549e6a78df57aa/examples/jsm/postprocessing/RenderPass.js#L57

    
      
          			renderer.setClearColor( this.clearColor, this.clearAlpha );
          
          
		}
          
          
		if ( this.clearDepth ) {
          
          
			renderer.clearDepth();
          
          
		}
          
          
		renderer.setRenderTarget( this.renderToScreen ? null : readBuffer );
          
          
		// TODO: Avoid using autoClear properties, see https://github.com/mrdoob/three.js/pull/15571#issuecomment-465669600
          		if ( this.clear ) renderer.clear( renderer.autoClearColor, renderer.autoClearDepth, renderer.autoClearStencil );
          		renderer.render( this.scene, this.camera );
          
          
		if ( this.clearColor ) {
          
          
			renderer.setClearColor( this._oldClearColor, oldClearAlpha );
          
          
		}

Mugen87 · July 24, 2021, 8:10am

Normally EffectComposer swaps the read and write buffer after a pass. When RenderPass is used, it is usually the first pass in the pass chain. Hence, it’s possible to directly write in the read buffer and safe the swap and the corresponding overhead.

Topic		Replies	Views
Using multiple RenderPass but rendering to seperate buffers? Questions materials , post-processing , effect-composer , rendering	2	620	December 5, 2022
RenderPass clearing prior Shader Pass' renders Questions post-processing	2	1285	February 20, 2019
three.js post processing maskpass with multiple renderpass never works Questions post-processing	8	5483	June 28, 2018
What is wrong with WebGL postprocessing backgrounds example? Questions examples , post-processing	7	1667	February 12, 2019
Filmpass postprocessing Questions materials , geometry , shaders , animation , threejs	18	906	September 24, 2023

RenderPass appears to write to the "readBuffer"?

Related Topics