Not falling back to root node and getting null breaks animation

Yoshiki_Ohshima · June 24, 2023, 12:10am

Hi, I track down a problem to this commit:

It removes a “||” case and returns null sometimes.

I cannot tell the reason for it but it breaks an animation that used to work.

The relevant code is here:

croquet/microverse/blob/6302d8d8a1052e3e0ac077386794a9665fbab278/behaviors/croquet/fullBodyAvatar.js#L83


      
              this.shape.add(group);
          
              if (this.myInterval) {
                  clearInterval(this.myInterval);
                  delete this.myInterval;
              }
          
              this.animationsPromise.then((animations) => this.animate(animations));
          }
          
          animate(animations) {
              const mixer = new Microverse.THREE.AnimationMixer(this.avatarModel);
          
              this.avatarModel.animations = animations;
          
              const [
                  idle,
                  walking,
                  running,
              ] = this.avatarModel.animations;

It loads idling, walking and running animation in glb, and use it to animate the Ready Player Me avatars. Now the targetNode on line 426 can be null, the following check fails.

At this moment I don’t know what problem it was causing, but it looks like the fix was not innocuous.