MaterialLoader.parse() doesn't honor lights property

Questions
1

In MaterialLoader.parse() I’ve noticed that the lights property used in ShaderMaterial isn’t being copied from the JSON.
Is this intentional or a bug?

1 Like
2

That looks like an oversight. Same for the clipping property.

Are you interested in fixing this with a PR?

1 Like
3

Yes, thank you. I will tomorrow.

1 Like
4

fix: MaterialLoader now honors clipping and lights properties by tfreifeld · Pull Request #25891 · mrdoob/three.js (github.com)

Hope I did it correctly :slight_smile:

1 Like