tomf
September 25, 2022, 7:52am
1
I just changing OrbitControls to FlyControls.
However, it seems FlyControls is not working with PerspectiveCamera.
Am I missing some props for FlyControls?
I tried google. However, I cant find the react-three sample with FlyControls
function Product() {
return (
<Suspense fallback={null}>
<Canvas >
<PerspectiveCamera makeDefault fov={90} position={[0, 0, 10]} />
<FlyControls
autoForward={false}
dragToLook={false}
movementSpeed={10}
rollSpeed={0.005}
makeDefault
/>
<color args={[0, 0, 0]} attach="background" />
<Model />
<ambientLight intensity={0.1} />
</Canvas>
</Suspense>
)
}
drcmda
September 25, 2022, 8:59am
2
the abstraction in drei seems to be very old, it doesn’t react to changing the default camera. i’ve also looked into three-stdlib/flycontrols and it seems broken, it has constructor side-effects and doesn’t use pointer events. i’ve fixed both. it supports camera switches and should also work on mobile now.
Mugen87
September 25, 2022, 9:12am
4
Sorry, but this statement is just wrong. The example works as intended on desktops (which was the original target platform): three.js webgl - fly controls - earth
drcmda
September 25, 2022, 9:42am
5
well, it may be intended to be like that, i don’t know, it still has constructor side effects and doesn’t work on mobile. not picking up on changed cameras was drei’s fault.
but either way, all three are fixed: fragrant-silence-yser4d - CodeSandbox
Mugen87
September 25, 2022, 9:49am
6
It’s fair to say that FirstPersonControls
and FlyControls
should be ported to Pointer Events. TBH, I’m a bit surprised both classes were overlooked when other controls like OrbitControls
or TransformControls
were updated.
The side effects issue is also something that should be fixed. The related discussion is:
opened 10:30PM - 28 Oct 20 UTC
Suggestion
**Is your feature request related to a problem? Please describe.**
From what … I can tell, the vast majority of Three does not have side effects in the constructor. However, some (notably, Controls like `OrbitControls` and some others) subscribe to the DOM node in the constructor.
This makes some coding patterns unnatural (e.g. when used from React components) because we can't safely create the objects early without triggering the subscriptions, and thus we have to delay creating them just before we're ready for the subscription to happen.
**Describe the solution you'd like**
Although all Controls appear to attach DOM listeners in their constructor, some of them have `connect / disconnect` or `attach / detach` method pairs. My proposal is twofold:
- Standardize on a set of convention for the method pair name across all Controls (and possibly, other objects, if any, that perform DOM subscriptions in Three).
- **Behavior change:** Do not connect by default — require the user to call `connect`.
The desired behavior is that constructing a Controls object never performs side effects, and it is safe to rely on GC to collect the object if it never gets used. Also, the desired behavior is that calling `connect()` and then `disconnect()` is equivalent to having just constructed the Controls object. You should be able to cycle them multiple times.
Regarding the API, I would propose to keep the constructor arguments as is, in order to make `connect() / disconnect()` a convention that can be dealt with in an abstraction without "knowing" about a particular Control being used.
For example:
```js
let controls = new OrbitControls(camera, domElement)
controls.connect(); // subscribes
controls.disconnect(); // unsubscribes
controls.connect(); // subscribes again
controls.connect(); // can't connect while connected — I think this should throw to find coding mistakes
```
**Describe alternatives you've considered**
* Standardize on method names, but start out connected (like some Controls) already do. While this somewhat helps our use case, it's a bit convoluted to call `disconnect()` right after creating so it takes away from the goal to make this pattern feel first-class in React. The upside of this is that it wouldn't break existing consumers. (Even the method names could be added to classes with `attach / detach` as aliases until the next breaking change is viable.)
* Instead of a `disconnect()` API, have `connect()` return a disconnecting function. This is a popular pattern in some communities but Three seems to have a more traditional object-oriented API so it doesn't seem to fit.
* Have `connect()` accept the DOM node instead of the constructor. There is some benefit to this because it lets us create an object even before we have the DOM node if it's more natural for code organization. The downside of this is that different Controls might take different options, so the knowledge about this has to be leaked to the abstraction managing the `connect / disconnect` lifetime. Now it has to be involved with passing their options through. In a declarative paradigm like React, options can potentially change any time, so it would have to know how to compare the "previous" and the "next" options to avoid constantly reattaching.
* Do nothing. We have a viable workaround, but it's not ideal from the perf perspective (https://github.com/facebook/react/issues/20090#issuecomment-716652603) and it's likely to bite more people in the future. So it would be good to resolve this at the upstream level.
Thanks!
drcmda
September 25, 2022, 9:51am
7
yes, very odd. fly-controls was also the last remaining control that had these issues which is why i was wondering, i was sure we fixed it but this one must’ve fallen out. can these controls be upstreamed to jsm/controls perhaps? though we use types, which probably makes it harder.
Mugen87
September 25, 2022, 9:55am
8
I think I have the time to update both controls next week. I remember now that I have filed PRs for both classes in the past but Ricardo and I were not sure about renaming public variables and methods (meaning moving from the “mouse” to the “pointer” syntax), see.
mrdoob:dev
← Mugen87:dev50
opened 02:30PM - 24 Aug 20 UTC
see [#20161 (comment)](https://github.com/mrdoob/three.js/pull/20161#issuecommen… t-678796016).
mrdoob:dev
← Mugen87:dev45
opened 01:38PM - 24 Aug 20 UTC
see https://github.com/mrdoob/three.js/pull/20161#issuecomment-678796016
I’ll just fix the events for now and file different PRs for the renaming issue. That should be the less blocking approach.
2 Likes
Mugen87
September 27, 2022, 9:02am
9
FYI: Both controls support pointer events now. Will be available with r145
.
mrdoob:dev
← Mugen87:dev70
opened 10:11AM - 25 Sep 22 UTC
Related issue: #20170, #20168
**Description**
This PR moves `FlyControls` … and `FirstPersonControls` from mouse to pointer events.
The original PRs were not merged since we were unsure about renaming properties and methods in the public scope. However, the affected entities are no part the actual public API so it is safe to rename them.
1 Like