How to actually remove a line object?

Rene_Veerman · February 15, 2021, 1:56pm

i’ve got the following piece of code that won’t actually remove lines.
no errors are thrown, but it just won’t do what it should (also according to the threejs manual, i believe)

github.com

nicerapp/nicerapp_v2/blob/aa34b0ad00ce14e75c3663493beae7c4bfe24845/nicerapp/vividComponents/na3D.source.js#L133



var 
it = p.it,
parent = t.items[it.parent],
haveLine = false;

for (var j=0; j<t.lines.length; j++) {
    if (t.lines[j].it === it) {
        haveLine = true;
    } else {
        t.scene.remove(t.lines[j]);
        t.lines[j].geometry.dispose();
    }
}

if (parent && parent.model) {
    if (!haveLine) {
        var 
        geometry = new THREE.Geometry(), 
        p1 = it.model.position, 
        p2 = parent.model.position;

i’m probably making another beginner’s mistake, but i’d love some help here…

FYI : the live demo is at 3D file manager on nicer.app

BTW : i’ve decided to truly opensource my entire framework, 3D stuff included, under the Creative Commons Attribution license. I’ll be making the necessary file uploads to github later today
This will make ALL of my code free for any type of use, including commercial applications…
I’ll be living on donations instead of hoping to beat people in court. I just like that way of life better.

Omar_Shehata · February 15, 2021, 7:00pm

Have you tried reproducing the issue in a minimal ThreeJS scene and post it on JSFiddle/CodeSandbox etc? That’ll make it easier for people on the forum here to see where the issue might be (and might help you resolve it by narrowing down the issue).

One reason why this may not be visually removing the expected line is if you’re creating additional lines and not saving them in the t.lines array. Or you’re somehow adding them twice etc?

Rene_Veerman · February 15, 2021, 7:17pm

to reproduce this particular issue for use in jsFiddle (which, granted, does allow people to actually test modifications, which is very useful), is a lot of overhead for me.

i’ll have to think carefully about it.

i may want to reproduce the ability to test changes to my own code on my own site in much the same manner as jsFiddle does, instead.

(my framework is at a crossroads right now, i don’t quite know which of the major new features[1] i want to develop first)

[1] social media, forums, 3D info browser (princeton published free thesaurus data at http://wordnet.princeton.edu), 3D file manager, jsFiddle functionality, etc, etc

i’m open to tips about what the world would need first

Rene_Veerman · February 17, 2021, 5:27am

it was a silly beginner’s mistake after all (phew) …

github.com

nicerapp/nicerapp_v2/blob/7e34c7201d53e95de1744cab23556244d97e4b36/nicerapp/vividComponents/na3D.source.js#L136


var 
it = p.it,
parent = t.items[it.parent],
haveLine = false;
for (var j=0; j<t.lines.length; j++) {
    if (t.lines[j]) {
        if (t.lines[j].it === it) {
            haveLine = true;
        } else {
            t.scene.remove(t.lines[j].line);
            t.lines[j].geometry.dispose();
            delete t.lines[j];
        }
    }
}
if (parent && parent.model) {
    if (!haveLine) {
        var 
        geometry = new THREE.Geometry(),

Topic		Replies	Views
Removing a line from LineSegments Questions geometry	5	1506	February 19, 2020
Delete line created using buffergeometry Questions geometry	1	1507	October 22, 2019
Deleting or updating a line Questions line	5	856	May 30, 2022
Removing models from scene Questions geometry	23	3402	December 27, 2021
Disposing LineSegments Questions dispose	1	720	May 30, 2019

How to actually remove a line object?

Related topics