DRACOLoader object URL not disposed

trusktr · December 22, 2022, 2:46am

This is never disposed:

mrdoob/three.js/blob/309b00afb6dcbc5e6c58e72f10eaa8d2e8888c83/examples/jsm/loaders/DRACOLoader.js#L266


      
          				const fn = DRACOWorker.toString();
          
          
				const body = [
          					'/* draco decoder */',
          					jsContent,
          					'',
          					'/* worker */',
          					fn.substring( fn.indexOf( '{' ) + 1, fn.lastIndexOf( '}' ) )
          				].join( '\n' );
          
          
				this.workerSourceURL = URL.createObjectURL( new Blob( [ body ] ) );
          
          
			} );
          
          
		return this.decoderPending;
          
          
	}
          
          
	_getWorker( taskID, taskCost ) {
          
          
		return this._initDecoder().then( () => {

trusktr · December 22, 2022, 2:47am

Hmm, will the browser GC it eventually, without calling revokeObjectURL, f.e. when no longer referencing the DRACOLoader?

Mugen87 · December 22, 2022, 9:59am

It would be probably cleaner to include the following into the dispose() method of DRACOLoader.

if ( this.workerSourceURL !== '' ) {

     URL.revokeObjectURL( this.workerSourceURL );

}

@donmccurdy Do you see any downsides in doing this?

donmccurdy · December 22, 2022, 3:14pm

At some point I’d like to rework DRACOLoader to pool workers among different loader instances, but I’ve been meaning to do that for a while and haven’t found time. That would require a slightly different strategy. But in the meantime yes – we should probably just revoke the URLs here.

Mugen87 · December 22, 2022, 3:19pm