OK, I’ll continue to improve it.
2 Likes
I found out that antialas was turned on and dpr was set before.
If turn them off, can reach about 12fps on Mac when the window is maximized.
If stepStride is set to 2, it can run to about 28fps.
Demo Demo2
Hey @gkjohnson, im trying to implement your GTAOPass in my Angular project, but Im getting Errors when rendering. I took your sandbox into my app. I also adjusted the version, but some files have r114 and some have r116. Im on r119 and tried both, down and upgrading.
Would be nice to have that in threejs/examples actually.
this.GTAO = new GTAOPass(this.scene, this.camera)
this.composer.addPass(this.GTAO)
Does it need to have a rendertarget?
This is the error
THREE.WebGLProgram: shader error: 0 35715 false gl.getProgramInfoLog invalid shaders THREE.WebGLShader: gl.getShaderInfoLog() fragment
ERROR: 0:178: ‘mapTexelToLinear’ : no matching overloaded function found
ERROR: 0:178: ‘=’ : dimension mismatch
ERROR: 0:178: ‘assign’ : cannot convert from ‘const mediump float’ to ‘highp 4-component vector of float’
Hi @Fluqz. Without a demonstration of the issue I can’t do a lot to help.
some files have r114 and some have r116
Yes some of the files in the repo use different versions of three because it’s time consuming to keep all the sub projects up to date but the way they’re used shouldn’t cause issues. The versions should be made consistent if it’s going to be used in a project, though.
Does it need to have a rendertarget?
I’m not sure what you mean by this.
Keep in mind that three.js has been updated to use WebGL2 by default in 119 at least which means that shaders may need to be updated to work correctly.
1 Like
4 Likes