Effect Composer Gamma Output Difference

[DolphinIQ]

@looeee

Some more considerations for post processing:

• some passes need to be in linear space (before tone-mapping) and some need to be done after. Some can be done before or after but you’ll get different results (e.g. vignette).
• Outline effect looks like it has tone mapping built in (probably incorrect?)
• AdaptiveToneMappingPass and ToneMapShader have filmic tonemapping built in. We should change that to ACESFilmic.

Before tone mappings: bloom, lensflare etc
Then, in order: 1. tonemapping 2. gamma correction
After tone mapping: brightness, contrast, FXAA, SMAA, color correction
Order not important (or, choose what looks best to you): DOF, vignette, film grain etc.

I’m not sure where where exposure comes into this - either before all passes, or just before tone mapping?

Wow, thanks @looeee! This is some great, useful info I haven’t seen anywhere else

@looeee

• It would be great if a final tone mapping pass was automatic when using the EffectComposer. Even better, combine color correction/tonemapping/brightness/contrast as the final pass (again, that’s what Unreal does I think).

That would be the dream scenario
but removing built in color corrections inside some passes would be a great start. Its simple to just add toneMapping, gamma etc at the end of the composer chain, but what complicates things is selfish passes with corrections built in, that break the chain.
Would Takahirox’s PR fix that issue?

Also Im not sure I got an answer for this, but why would renderPass and renderPass + copyPass give different colorspace renders? (or different results at all?) This actually seems to happen with 1 or more passes added after renderPass, regardless of the pass type (but a basic copyPass shows it clearly).
And why does it suddenly stop respecting the renderer.outputEncoding?