hello people, can anyone help me update this spectacular example by @prisoner849 to r133 please? it uses r124’s THREE.Geometry as to use the geometry vertices and geometry faces, i have been trying for hours going round in circles trying to update to r133 bufferGeometry with absolutely no luck s…

You will find migrating instructions in this thread: https://discourse.threejs.org/t/three-geometry-will-be-removed-from-core-with-r125/22401

@vielzutun.ch ,thanks for your reply, yes i know the thread well, i understand the basic principles of bufferGeometry attributes, i’m just struggling understanding how to access the attributes in the right way… here is what i am trying so far, i am served with this error… [image] i’m still trying …

[image] Lawrence3DPK: geometry.attributes.position.index.count position.index.count is something strangle, it should be position.count or, if you want to rely on index, then it’s geometry.index

@prisoner849 sorry i had the wrong code in the pen, just updated, i’m having real difficulty working it out, there’s no relativity in the original vertices count and the geometry.attributes.position.count, i’m trying, will update you if i find the solution, just trying to experiment kind of blindly…

@prisoner849 i’ve found something very odd, if i simply import the deprecated Geometry class from examples/jsm/deprecated/Geometry.js and update to R133 but keep your original code it still breaks with the error… [image] would have expected that to work, unless the deprecated Geometry.js has been …

InstancedMesh with morph attributes is not supported. You have to delete the morph attributes of the geometry if you want to use instanced rendering.

@Mugen87 thanks man! that did help a lot! i tried loading a glb without morph attributes so importng the Deprecated Geometry.js with r133 worked a charm! after being able to see and debug the result i managed to upgrade the example in question to use r133 and bufferGeometry without the need to impo…

With modification to EdgesGeometry in r145 I was able to set contitional glowing for fat lines of batched geometry :sweat_smile: :

Wow @prisoner849 now that’s awesome! Looks really good! How’s the performance?

@Lawrence3DPK works pretty smooth even on my 9yo machine with built-in Intel graphics :slight_smile:

Update 124 to r133 buffer geometry faces

Questions

prisoner849 October 18, 2022, 4:31pm 15

@Lawrence3DPK All the stuff is here: Tetrahedra (fat lines, batching, texelFetch)

Topic		Replies	Views
THREE.Geometry will be removed from core with r125 Discussion geometry	95	44771	December 19, 2021
How to properly upgrade older version project? Questions geometry	1	812	June 15, 2021
Getting THREEx geometric glow working on THREE.js v130 Questions geometry , buffergeometry	0	913	October 1, 2021
Geometry -> buffergeometry migration Questions geometry , buffergeometry	4	1670	November 22, 2021
BufferGeometry not accepting attributes? Questions buffergeometry	4	882	October 15, 2017

Update 124 to r133 buffer geometry faces

Related topics